[PATCH] D143704: [flang] Feature list plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00d0749f92ec: [flang] Feature list plugin (authored by elmcdonough). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 511537. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 510553. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 509395. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507572. Herald added a subscriber: mgrang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt

[PATCH] D143704: [flang] Feature list plugin

AlexisPerry added a comment. In D143704#4214279 , @elmcdonough wrote: > Could you post a link to the failed build please @Renaud-K? I'd like to see > if I can diagnose what's going wrong. Here is another helpful issue link regarding the failed build:

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. The pre-commit was failing. Please do not commit without at least checking that the pre-commit is fine. https://buildkite.com/llvm-project/premerge-checks/builds/142487#018707c0-3ec0-4daa-a3a4-ffc815807994 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507486. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Could you post a link to the failed build please @Renaud-K? I'd like to see if I can diagnose what's going wrong. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 ___

[PATCH] D143704: [flang] Feature list plugin

Renaud-K reopened this revision. Renaud-K added a comment. This revision is now accepted and ready to land. Buildbot is failing with Failed Tests (2): Flang :: Examples/feature-list-class.f90 Flang :: Examples/feature-list-functions.f90 CHANGES SINCE LAST ACTION

[PATCH] D143704: [flang] Feature list plugin

elmcdonough updated this revision to Diff 507231. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 Files: flang/examples/CMakeLists.txt flang/examples/FeatureList/CMakeLists.txt flang/examples/FeatureList/FeatureList.cpp

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Sorry about that. I was trying to look for a fix, and I think it has something to do with these recent changes . I'll have a new revision soon. Repository: rG LLVM Github

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. I reverted your patch since the buildbot was failing for couple of hours. Feel free to re-land it when you have a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. pre-commit ci is showing a different failure: TEST 'Flang :: Examples/feature-list-class.f90' FAILED Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/flang-new -fc1 -load

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. In D143704#4202146 , @elmcdonough wrote: > Haven't been able to check this yet, but I think it might be due to the tests > expecting a deterministic output. I've only ever tested on Ubuntu WSL, so > its possible the order

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Haven't been able to check this yet, but I think it might be due to the tests expecting a deterministic output. I've only ever tested on Ubuntu WSL, so its possible the order is different on different platforms. I think replacing CHECK-NEXT with CHECK-DAG might

[PATCH] D143704: [flang] Feature list plugin

DavidSpickett added a comment. Specifically https://lab.llvm.org/buildbot/#/builders/181/builds/15552. Though it is only the sharedlibs build failing, I don't know why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. You have some failed buildbots. Can you revert it if you don't have a quick fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[PATCH] D143704: [flang] Feature list plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde91fd03f72: [flang] Feature list plugin (authored by elmcdonough). Changed prior to commit: https://reviews.llvm.org/D143704?vs=502691=505991#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143704: [flang] Feature list plugin

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as it doesn't affect core features. Comment at: flang/examples/FeatureList/FeatureList.cpp:40-43 +const auto [it, ins] = frequencies.insert({name, 1}); +if

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Herald added a subscriber: jplehr. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704 ___ cfe-commits mailing list