HazardyKnusperkeks added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2665
+if (Style.isVerilog() && Precedence == prec::Comma &&
+VerilogFirstOfType != nullptr) {
+ addFakeParenthesis(VerilogFirstOfType, prec::Comma);
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6e473aeffdc1: [clang-format] Put ports on separate lines in
Verilog module headers (authored by sstwcw).
Changed prior to commit:
owenpan added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2665
+if (Style.isVerilog() && Precedence == prec::Comma &&
+VerilogFirstOfType != nullptr) {
+ addFakeParenthesis(VerilogFirstOfType, prec::Comma);
sstwcw wrote:
>
sstwcw added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2665
+if (Style.isVerilog() && Precedence == prec::Comma &&
+VerilogFirstOfType != nullptr) {
+ addFakeParenthesis(VerilogFirstOfType, prec::Comma);
owenpan wrote:
>
owenpan added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2665
+if (Style.isVerilog() && Precedence == prec::Comma &&
+VerilogFirstOfType != nullptr) {
+ addFakeParenthesis(VerilogFirstOfType, prec::Comma);
And other places
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
Thank you for adding the tests, as I don't know Verilog then I can't really
comment on the correctness, as you are mostly in your own scoped verilog
functions, I'm fine with
sstwcw updated this revision to Diff 498376.
sstwcw marked 3 inline comments as done.
sstwcw added a comment.
- add tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143825/new/
https://reviews.llvm.org/D143825
Files:
sstwcw marked 3 inline comments as done.
sstwcw added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2836
+ Tok = Tok->getNextNonComment();
+ } else if (Tok->is(tok::hashhash)) {
+// Concatenation. Skip.
MyDeveloperDay
MyDeveloperDay added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2836
+ Tok = Tok->getNextNonComment();
+ } else if (Tok->is(tok::hashhash)) {
+// Concatenation. Skip.
are we covering these cases in the unit tests
sstwcw created this revision.
sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan,
rymiel.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
New:
module mh1
(input var
10 matches
Mail list logo