[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

rupprecht added a comment. This has already been reverted, but I found a breakage (not a crash) caused by this: #include class Base { protected: int member; }; template struct Subclass : public Parent { static_assert(std::is_base_of::value, "Parent

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

alexfh added a comment. In D143840#4147582 , @joanahalili wrote: > In D143840#4147234 , @joanahalili > wrote: > >> Heads up: We are experiencing a series of clang crashes because of this >> commit. >> >> What

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

joanahalili added a comment. In D143840#4147234 , @joanahalili wrote: > Heads up: We are experiencing a series of clang crashes because of this > commit. > > What we already have so far: > > Unhandled DeclRefExpr > UNREACHABLE executed at

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

joanahalili added a comment. Heads up: We are experiencing a series of clang crashes because of this commit. What we already have so far: Unhandled DeclRefExpr UNREACHABLE executed at clang/lib/CodeGen/CGExpr.cpp:2958! We are now working on a reproducer. Repository: rG LLVM Github

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8498ba6c2860: [clang] Add the check of membership for the issue #58674 and improve the lookup… (authored by lime). Repository: rG LLVM Github

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 499374. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 499339. lime edited the summary of this revision. lime added a comment. Updated as suggested. I will do a stage-2 build before landing the patch to confirm whether it would case another crash, and it takes time. CHANGES SINCE LAST ACTION

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I don't have a great idea of this section of code, but as code-owner I guess I'm stuck approving/disapproving of this :) Barring additional information, I think I have to accept this

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

cor3ntin added a comment. Thanks for working on this issue. I don't feel confident commenting on this patch's approach (I think @erichkeane is your best bet), but the small typo does make a pretty big difference here! Comment at: clang/include/clang/AST/DeclCXX.h:1549 ///

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime added inline comments. Comment at: clang/lib/AST/CXXInheritance.cpp:84 [BaseDecl](const CXXBaseSpecifier *Specifier, CXXBasePath ) { return Specifier->getType()->getAsRecordDecl() && FindBaseClass(Specifier, Path, BaseDecl);

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime updated this revision to Diff 496742. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

lime created this revision. lime added reviewers: aaron.ballman, erichkeane, cor3ntin, clang-language-wg. Herald added a subscriber: yaxunl. Herald added a project: All. lime requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch