This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG504aa8ae941e: [include-cleaner] Better support ambiguous std
symbols (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
hokein marked an inline comment as done.
hokein added a comment.
Thanks for the review!
Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:85
+Hints isPublicHeader(const FileEntry *FE, const PragmaIncludes *PI) {
+ return (PI->isPrivate(FE) || !PI->isSelfConta
hokein updated this revision to Diff 497233.
hokein marked 2 inline comments as done.
hokein added a comment.
handle the case where PI is null.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143906/new/
https://reviews.llvm.org/D143906
Files:
cla
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:85
+Hints isPublicHeader(const FileEntry *FE, const PragmaIncludes *PI) {
+ return (PI->isPri
hokein added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:174
const PragmaIncludes *PI) {
+ if (auto Headers = specialStandardSymbols(S); !Headers.empty())
+return Headers;
kad
hokein updated this revision to Diff 497110.
hokein marked 3 inline comments as done.
hokein added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143906/new/
https://reviews.llvm.org/D143906
Files:
clang-tools-extra/in
kadircet added inline comments.
Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:104
+ }
+ if (FName == "remove") {
+if (FD->getNumParams() == 1)
nit: `else if`
Comment at: clang-tools-extra/include-cleaner/lib/FindHeader
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang-tools-extra.
By special-casing them at the moment. The tooling stdlib lib doesn't
support these symbols (most important one is std::
