[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

2023-02-17 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2b51c8cd2ac6: [clang-tidy] Clarify bugprone-branch-clone diagnostic message (authored by donat.nagy, committed by Donát Nagy m1nag...@protonmail.com). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

2023-02-14 Thread Donát Nagy via Phabricator via cfe-commits
donat.nagy added a comment. Thanks for the feedback! I can push the commit and I'll do so after a few days (if no changes are suggested). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143917/new/ https://reviews.llvm.org/D143917

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

2023-02-14 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. @donat.nagy Are you available to push the commit yourself? Otherwise I can help you with that, please let me know your name and email (must match those on your Github account) for attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

2023-02-13 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Personally I don't think such a small change is worth mentioning in the Release Notes, but maybe other reviewers think differently, let's give them a