[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. LGTM, and the summary of the discussion in the sync-up call matches my understanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 ___

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22e199e6afb1: [RISCV] Accept zicsr and zifencei command line options (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. This was discussed at today's RISCV sync-up call. We have a large conversion pending on the topic of isa compatibility checking, but there was a consensus that this was reasonable and could move forward. I'm going to be landing this change in the near future.

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. I've posted RFC: Resolving issues related to extension versioning in RISC-V which discusses some related issues (I think it complements this patch, rather than anything

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. We seem to have rough consensus here, but I'm going to wait roughly 24 hours before landing to give others time to comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497336. reames added a comment. Address @jrtc27's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497328. reames edited the summary of this revision. reames added a comment. Add docs, and rework description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files:

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. Thanks Philip. I started looking at this too, and agree that something like this is a good next step. I've been looking more closely at the GCC behaviour and noticed a couple of things that might be of interest: - `-march=rv64gc` results

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Personally happy with the concept then, seems consistent and overall helpful, just some nits Comment at: llvm/lib/Target/RISCV/RISCVFeatures.td:83-86 +

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. In D143953#4124649 , @jrtc27 wrote: > In D143953#4124636 , @reames wrote: > >> @jrtc27 Not sure if this changes your take, but I realized the variant being >> introduced is maybe much

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

jrtc27 added a comment. In D143953#4124636 , @reames wrote: > @jrtc27 Not sure if this changes your take, but I realized the variant being > introduced is maybe much less interesting than I'd first thought. We > generally make no effort to make sure

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. @jrtc27 Not sure if this changes your take, but I realized the variant being introduced is maybe much less interesting than I'd first thought. We generally make no effort to make sure an extension was defined in the spec version corresponding to our base revision.

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

jrtc27 added a comment. I'm fine with this approach but I think they should be filtered out of the ELF attributes, maybe also preprocessor macros? That is, treating them as a redundant no-op in the driver rather than like a true extension. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames created this revision. reames added reviewers: asb, frasercrmck, kito-cheng, jrtc27, craig.topper. Herald added subscribers: luke, VincentWu, vkmr, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,