[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. Updated DebugInfo test of OCaml binding. In D143984#4409015 , @dblaikie wrote: > When we migrated to github we gained higher fidelity for attributing authors > (we can now commit on someone's behalf but have the commit

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dblaikie added a comment. When we migrated to github we gained higher fidelity for attributing authors (we can now commit on someone's behalf but have the commit author properly recorded as the real author - we couldn't do that back on Subversion) - but I think it's meant that fail-mail from

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

steakhal added a comment. In D143984#4405961 , @dzhidzhoev wrote: > In D143984#4405875 , @steakhal > wrote: > >> I think this patch broke two build bots, and now the CI is red. >>

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4405875 , @steakhal wrote: > I think this patch broke two build bots, and now the CI is red. > https://lab.llvm.org/buildbot/#/builders/16/builds/49282 > https://lab.llvm.org/buildbot/#/builders/109/builds/65904 > >

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

steakhal added a comment. I think this patch broke two build bots, and now the CI is red. https://lab.llvm.org/buildbot/#/builders/16/builds/49282 https://lab.llvm.org/buildbot/#/builders/109/builds/65904 Could you please have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4418434c6de7: [DebugMetadata] Simplify handling subprograms retainedNodes field. NFCI (1/7) (authored by krisb, committed by dzhidzhoev).

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev updated this revision to Diff 529096. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4362988 , @dblaikie wrote: > In D143984#4358115 , @dzhidzhoev > wrote: > >> In D143984#4357517 , @dblaikie >> wrote: >> >>> Looks

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dblaikie added a comment. In D143984#4358115 , @dzhidzhoev wrote: > In D143984#4357517 , @dblaikie > wrote: > >> Looks like this series got approved - is it waiting on any particular >> feedback, or do you

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4357517 , @dblaikie wrote: > Looks like this series got approved - is it waiting on any particular > feedback, or do you need someone to commit it for you? I had been waiting for approval for the change of

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dblaikie added a comment. Looks like this series got approved - is it waiting on any particular feedback, or do you need someone to commit it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev updated this revision to Diff 522136. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. @krisb is out of office for some time, so she asked to retake and wrap up this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb updated this revision to Diff 504602. krisb added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

jmmartinez added a comment. Sorry for the delay, I was out-of-office. Patches 1 to 4 look good to me. If nobody raises concerns this week I'll mark them as accepted. I'm currently reviewing patch 5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb marked an inline comment as done. krisb added inline comments. Comment at: llvm/include/llvm/IR/DIBuilder.h:76 -/// Each subprogram's preserved labels. -DenseMap> PreservedLabels; +SmallVectorImpl & +getSubprogramNodesTrackingVector(const DIScope *S) {

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

aprantl added inline comments. Comment at: llvm/include/llvm/IR/DIBuilder.h:76 -/// Each subprogram's preserved labels. -DenseMap> PreservedLabels; +SmallVectorImpl & +getSubprogramNodesTrackingVector(const DIScope *S) { Do you need a writeable

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

jmmartinez added inline comments. Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags, AlignInBits); krisb

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb added a comment. @jmmartinez thank you for looking at this! Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags,

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

jmmartinez added inline comments. Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags, AlignInBits); I'll

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez. krisb added projects: LLVM, debug-info. krisb published this revision for review. Herald added a project: clang.