[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656399 , @aeubanks wrote: > In D144006#4656383 , @dzhidzhoev > wrote: > >> In D144006#4656371 , @aeubanks >> wrote: >> >>> Is

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656728 , @jmorse wrote: > Hi, > > Just to note that we've been seeing LTO crashes as a result of > rG3b449bd46a11a > (now > reverted on

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

jmorse added subscribers: StephenTozer, jmorse. jmorse added a comment. Hi, Just to note that we've been seeing LTO crashes as a result of rG3b449bd46a11a (now reverted on trunk), which @StephenTozer has kindly reduced down

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. In D144006#4656383 , @dzhidzhoev wrote: > In D144006#4656371 , @aeubanks > wrote: > >> Is there any issue with mixing IR built with >> `LLVMContext::enableDebugTypeODRUniquing()` and

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656371 , @aeubanks wrote: > Is there any issue with mixing IR built with > `LLVMContext::enableDebugTypeODRUniquing()` and without? I'm suspecting that > ThinLTO is mixing Rust and Clang IR which set that

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. F30438826: i.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 ___ cfe-commits mailing list

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4656350 , @aeubanks wrote: > Heads up, we're seeing issues from this in Chrome again, will try to post a > reduced repro (https://crbug.com/1500022) > > The reduced repro I found crashed very far back, so I'm

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. another observation, `opt` complained about some debug info due to setting `LLVMContext::enableDebugTypeODRUniquing()` and stripped it away, but `llc` happily accepted the debug info and crashed with the assertion above when emitting assembly. Repository: rG LLVM

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. Is there any issue with mixing IR built with `LLVMContext::enableDebugTypeODRUniquing()` and without? I'm suspecting that ThinLTO is mixing Rust and Clang IR which set that differently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. `../../llvm/lib/CodeGen/AsmPrinter/DwarfFile.cpp:110: void llvm::DwarfFile::addScopeVariable(LexicalScope *, DbgVariable *): Assertion 'Ret.second' failed.` is the crash btw Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

aeubanks added a comment. Heads up, we're seeing issues from this in Chrome again, will try to post a reduced repro (https://crbug.com/1500022) The reduced repro I found crashed very far back, so I'm guessing this patch caused bad debug info which caused an existing issue that doesn't handle

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4651955 , @hans wrote: > We're hitting an assert after this change: > > llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2331: > virtual void llvm::DwarfDebug::endFunctionImpl(const llvm::MachineFunction > *): >

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hans added a comment. We're hitting an assert after this change: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2331: virtual void llvm::DwarfDebug::endFunctionImpl(const llvm::MachineFunction *): Assertion `LScopes.getAbstractScopesList().size() == NumAbstractSubprograms &&

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8aab289b554: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Changed prior to commit:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 555845. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D158730. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 550270. dzhidzhoev added a comment. Rebased (on top of https://reviews.llvm.org/D155818). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 544711. dzhidzhoev added a comment. Rebased on top of https://reviews.llvm.org/D155818. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. In D144006#4437804 , @dzhidzhoev wrote: > In D144006#4435677 , @hoy wrote: > >> Hello, I'm seeing a build failure that seems related to this patch. I'm >> seeing the patch has been relanded

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. In D144006#4435677 , @hoy wrote: > Hello, I'm seeing a build failure that seems related to this patch. I'm > seeing the patch has been relanded and reverted a couple times and not sure > where it is right now. Can you please

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hoy added a comment. Hello, I'm seeing a build failure that seems related to this patch. I'm seeing the patch has been relanded and reverted a couple times and not sure where it is right now. Can you please confirm if the failure is related and fixed? Thanks. 2023-06-20T05:19:14.441-07:00]

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev added a comment. Thank you for reports! I've reverted it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 ___ cfe-commits mailing list

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

hans added a comment. We're seeing assertion failures in Chromium too. Reproducer for x86_64 Linux here: https://bugs.chromium.org/p/chromium/issues/detail?id=1456288#c2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

mstorsjo added a comment. This change triggers failed asserts when compiling code for at least arm and aarch64. It is reproducible with this reduced testcase: $ cat repro.c typedef long long a; typedef int b(); int c, d; long e, f; short g, j; void *h; short i[]; char k; a

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66511b401042: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Repository: rG LLVM Github

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 532642. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen/debug-info-codeview-unnamed.c

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 529100. dzhidzhoev added a comment. Added AutoUpdater, moving function-local types belonging to DICompileUnit to a corresponding DISubprogram. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/