This revision was automatically updated to reflect the committed changes.
Closed by commit rGcb2d04d41e47: [clangd] Hide inlay hints when using a macro
as a calling argument that with a… (authored by zyounan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144074/new/
https://reviews.llvm.org/D144074
zyounan updated this revision to Diff 500388.
zyounan added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144074/new/
https://reviews.llvm.org/D144074
Files:
clang-tools-extra/clangd/InlayHints.cpp
clang-tools-extra/clangd/un
zyounan added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:520
auto ExprStartLoc = SM.getTopMacroCallerLoc(E->getBeginLoc());
-auto Decomposed = SM.getDecomposedLoc(ExprStartLoc);
+auto Decomposed = SM.getDecomposedExpansionLoc(ExprStartLoc);
zyounan updated this revision to Diff 500387.
zyounan marked an inline comment as done.
zyounan added a comment.
Address the comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144074/new/
https://reviews.llvm.org/D144074
Files:
clang-tools-e
nridge added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:520
auto ExprStartLoc = SM.getTopMacroCallerLoc(E->getBeginLoc());
-auto Decomposed = SM.getDecomposedLoc(ExprStartLoc);
+auto Decomposed = SM.getDecomposedExpansionLoc(ExprStartLoc);
zyounan added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144074/new/
https://reviews.llvm.org/D144074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
zyounan created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
zyounan added reviewers: kadircet, nridge.
zyounan added a comment.
zyounan retitled this revision from "[clangd] Hide extra inlay hints for macro
as argument" to "[clangd] Hide inlay hints wh
