eugenis added a comment.
Hi,
Have you had a chance to look at this?
Repository:
rL LLVM
http://reviews.llvm.org/D14409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
In http://reviews.llvm.org/D14409#306272, @EricWF wrote:
> Does the `inline` keyword have any effect when it's on function definitions
> that are externally instantiated?
I could not detect any difference in behavior with or without inline keyword.
Remove it?
EricWF added a comment.
Does the `inline` keyword have any effect when it's on function definitions
that are externally instantiated?
Repository:
rL LLVM
http://reviews.llvm.org/D14409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
In http://reviews.llvm.org/D14409#306531, @eugenis wrote:
> In http://reviews.llvm.org/D14409#306379, @eugenis wrote:
>
> > In http://reviews.llvm.org/D14409#306272, @EricWF wrote:
> >
> > > Does the `inline` keyword have any effect when it's on function
> > >
eugenis closed this revision.
eugenis added a comment.
r255177
Thanks for the review!
Repository:
rL LLVM
http://reviews.llvm.org/D14409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
eugenis added a comment.
In http://reviews.llvm.org/D14409#306379, @eugenis wrote:
> In http://reviews.llvm.org/D14409#306272, @EricWF wrote:
>
> > Does the `inline` keyword have any effect when it's on function definitions
> > that are externally instantiated?
>
>
> I could not detect any
eugenis added a comment.
In http://reviews.llvm.org/D14409#306531, @eugenis wrote:
> In http://reviews.llvm.org/D14409#306379, @eugenis wrote:
>
> > In http://reviews.llvm.org/D14409#306272, @EricWF wrote:
> >
> > > Does the `inline` keyword have any effect when it's on function
> > >
eugenis added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D14409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis updated this revision to Diff 39750.
eugenis added a comment.
Applied the same change to . No idea how I missed it.
Repository:
rL LLVM
http://reviews.llvm.org/D14409
Files:
include/istream
include/ostream
include/sstream
include/streambuf
Index: include/streambuf
EricWF added a comment.
No changes are needed in ``?
Repository:
rL LLVM
http://reviews.llvm.org/D14409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis added a comment.
is an interesting case.
There are no cases of visibility attribute present on an out-of-class
definition but missing on an in-class declaration, so nothing needs to be done
for a switch to internal_linkage.
Setting hidden visibility on an "extern template" method is
eugenis created this revision.
eugenis added reviewers: mclow.lists, EricWF.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
No point in pretending that these methods are hidden - they are
actually exported from libc++.so. Extern template
12 matches
Mail list logo
