This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG801bd3265362: [clalng-format] Fix handling of TypeScript
tuples with optional last member (authored by taymonbeal, committed by owenpan).
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
Thank you for this LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144317/new/
https://reviews.llvm.org/D144317
___
cfe-commits
taymonbeal added a comment.
Can anyone please commit this? I don't have commit access. Thanks.
Name: Taymon A. Beal
Email: tay...@google.com
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144317/new/
https://reviews.llvm.org/D144317
taymonbeal updated this revision to Diff 498692.
taymonbeal added a comment.
Merge unit test into existing test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144317/new/
https://reviews.llvm.org/D144317
Files:
owenpan added reviewers: krasimir, HazardyKnusperkeks, rymiel.
owenpan added inline comments.
Comment at: clang/unittests/Format/FormatTestJS.cpp:2826
+TEST_F(FormatTestJS, TupleTypeWithOptionalLastElement) {
+ verifyFormat("type T = [number?];");
+}
Can you
taymonbeal created this revision.
taymonbeal added reviewers: MyDeveloperDay, owenpan.
Herald added a project: All.
taymonbeal requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
These were previously incorrectly treated as syntax errors.
