[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL added a comment. In D144347#4469770 , @ccotter wrote: > @PiotrZSL - checking back, do you plan to revisit this change soon (I think > there are some pending feedback and you planned some changes)? I'd like to > see this in change merged in.

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. @PiotrZSL - checking back, do you plan to revisit this change soon (I think there are some pending feedback and you planned some changes)? I'd like to see this in change merged in. Let me know if I can help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

njames93 requested changes to this revision. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:45 + +inline SourceRange getAnglesLoc(const Expr *MatchedCallee) { + if (const auto *DeclRefExprCallee = Use

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Extract DisableTypeMismatchSuggestion & that logic into separate check in bugprone category. TODO: Validate more situations with templates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:99 + unless(isExpansionInSystemHeader()), argumentCountIs(1U), + IgnoreDependentExpresions + ?

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL marked an inline comment as done. PiotrZSL added a comment. I will leave this review open for 1 more week, in case someone have some comments, and by someone I mean you @carlosgalvezp. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 +

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter accepted this revision. ccotter added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/readability/ForwardUsageCheck.cpp:98 + callExpr( + unless(isExpansionInSystemHeader()),

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL added a comment. In D144347#4222534 , @ccotter wrote: > Is it worth adding a cppcoreguidelines alias (ES.56)? Yes, you can pull this change (arc patch D144347 --nobranch) and create change that would depend

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Is it worth adding a cppcoreguidelines alias (ES.56)? Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/forward-usage.rst:98 + +.. option:: DisableTypeMismatchSuggestion + Curious what others thing but I think the tool

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL updated this revision to Diff 503357. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 Files:

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL updated this revision to Diff 503297. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 Files:

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL updated this revision to Diff 503092. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL updated this revision to Diff 498666. PiotrZSL added a comment. Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp. PiotrZSL marked