[PATCH] D144355: [clang-format][NFC] Clean up nullptr comparison style

2023-02-21 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ef289e5b24b: [clang-format][NFC] Clean up nullptr comparison style (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144355: [clang-format][NFC] Clean up nullptr comparison style

2023-02-19 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. @MyDeveloperDay Looking at the return lines in the functions in `FormatToken.h` got me to check the similar functions not changed by this patch. And I noticed that the final `==` in `isCSharpKeyword` seems to return true when the token is not a keyword. Repository:

[PATCH] D144355: [clang-format][NFC] Clean up nullptr comparison style

2023-02-19 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example,