[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. >>> Do you have a suggestion how we can move this patch forward? >> >> IIRC, D150688 + the diff in >> https://github.com/llvm/llvm-project/issues/62719#issuecomment-1552903385 + >> upgrading the pre-merge linux bot should take care of all

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4356160 , @hans wrote: > In D144509#4350052 , @Mordante > wrote: > >> In D144509#4349921 , @thakis wrote: >> >>> Reverted this and

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4350052 , @Mordante wrote: > In D144509#4349921 , @thakis wrote: > >> Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 >>

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4349051 , @hans wrote: > In D144509#4347562 , @glandium > wrote: > >> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c >>

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. Is https://reviews.llvm.org/D144509#4347562 fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 ___ cfe-commits mailing list

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4350148 , @thakis wrote: > https://github.com/llvm/llvm-project/issues/62719 is independent of chromium > and others have reported problems above too, from what I understand. Is that > not accurate? That bug report

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349017 , @dyung wrote: > I'm not really sure where else to post this, but the pre-merge linux bot > still seems to be running 3.18.4. > >

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. https://github.com/llvm/llvm-project/issues/62719 is independent of chromium and others have reported problems above too, from what I understand. Is that not accurate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349921 , @thakis wrote: > Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 > for now. > > Sorry this is such a pain to

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 for now. Sorry this is such a pain to land :( (See also discussion over in D150688 )

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4349399 , @mstorsjo wrote: > In D144509#4349051 , @hans wrote: > >> In D144509#4347562 , @glandium >> wrote: >> >>> FYI,

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

mstorsjo added a comment. In D144509#4349051 , @hans wrote: > In D144509#4347562 , @glandium > wrote: > >> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c >>

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4347562 , @glandium wrote: > FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c > is > causing problems on Windows compiler-rt for some reason I haven't

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

dyung added a comment. I'm not really sure where else to post this, but the pre-merge linux bot still seems to be running 3.18.4. https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837-4fc2-baec-fca595969219 CMake Error at CMakeLists.txt:3 (cmake_minimum_required):

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. So the problem is that `CMakePolicy.cmake` is not included in `compiler-rt/CMakeLists.txt`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. It's related, though, because now that I look at my build logs, the difference between when it works and when it doesn't is `/MT` vs `-MD` when compiler-rt is compiled. The main peculiarity on our end, though, is that the Windows compiler-rt is cross-compiled.

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4347604 , @mstorsjo wrote: > See D150688 - I believe that might fix the > issue you're seeing, as that one mentions compiler-rt. Unfortunately, it doesn't. FWIW, the errors looks

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

mstorsjo added a comment. In D144509#4347562 , @glandium wrote: > FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c > is > causing problems on Windows compiler-rt for some reason I

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. Herald added subscribers: bviyer, ekilmer, jplehr. FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c is causing problems on Windows compiler-rt for some reason I haven't identified yet (with cmake

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44c6b905f852: [CMake] Bumps minimum version to 3.20.0. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 500547. Mordante added a comment. Rebased to test CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante updated this revision to Diff 499569. Mordante added a comment. Herald added a subscriber: mstorsjo. Try to fix AIX CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 Files:

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

sivachandra accepted this revision. sivachandra added a comment. Herald added subscribers: sstefan1, JDevlieghere. OK for libc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: bollu, tstellar, mehdi_amini, MaskRay, ChuanqiXu, to268, kparzysz, thieta, tschuett, mgorny, stellaraccident, mizvekov, ldionne, jdoerfert, phosek. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1,