This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe419e22ff6fd: [CodeGen] Stop storing alignment information
into pointers in Address (authored by ahatanak).
Repository:
rG LLVM Github Monorepo
C
ahatanak updated this revision to Diff 500222.
ahatanak added a comment.
Remove AddressImpl altogether.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144686/new/
https://reviews.llvm.org/D144686
Files:
clang/lib/CodeGen/Address.h
Index: clang/l
aeubanks added inline comments.
Comment at: clang/lib/CodeGen/Address.h:28
-// We try to save some space by using 6 bits over two PointerIntPairs to store
-// the alignment. However, some arches don't support 3 bits in a PointerIntPair
-// so we fallback to storing the alignmen
ahatanak added a comment.
I don't have a test case for this change because there is a bug that prevents
using the maximum allowed alignment (see
https://github.com/llvm/llvm-project/issues/60752).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1446
ahatanak created this revision.
ahatanak added reviewers: aeubanks, efriedma, rjmccall.
ahatanak added a project: clang.
Herald added a project: All.
ahatanak requested review of this revision.
This fixes a bug introduced in https://reviews.llvm.org/D142584. The patch
reduced the number of bits u
