[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

This revision was automatically updated to reflect the committed changes. Closed by commit rG48f97e575137: [FlowSensitive] Log analysis progress for debugging purposes (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D144730?vs=507418=507678#toc Repository: rG LLVM

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

ymandel accepted this revision. ymandel added a comment. Awesome, thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:18 + +class ControlFlowContext; +class TypeErasedDataflowAnalysis; Maybe comment on the need for these vs including the

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:186 + Logger () const { +return DACtx->getOptions().Log ? *DACtx->getOptions().Log : Logger::null(); + } xazax.hun wrote: > If we already have a

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall updated this revision to Diff 507418. sammccall marked 3 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files:

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Logger.cpp:17 +Logger ::null() { + struct NullLogger : Logger {}; + static auto *Instance = new NullLogger(); Adding `final`? Just in case it can help with devirtualization.

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:186 + Logger () const { +return DACtx->getOptions().Log ? *DACtx->getOptions().Log : Logger::null(); + } If we already have a `NullLogger`, I

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall added a comment. In D144730#4211222 , @NoQ wrote: > I love such debugging facilities! They're a massive boost to developer > productivity compared to ad-hoc debug prints, and they allow new contributors > to study how the tool works. I'm

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

NoQ added a comment. I love such debugging facilities! They're a massive boost to developer productivity compared to ad-hoc debug prints, and they allow new contributors to study how the tool works. I'm excited to see how this thing turns out. In the static analyzer's path-sensitive engine

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall added a reviewer: xazax.hun. sammccall added a comment. Herald added a subscriber: rnkovacs. Thanks! I cleaned up a bit and added tests, as well as a `-dataflow-log` flag to make this easy to access when running unit tests, tidy checks etc. The HTML experiments seem to have validated

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall updated this revision to Diff 507067. sammccall marked 2 inline comments as done. sammccall retitled this revision from "[FlowSensitive][WIP] log analysis progress for debugging purposes" to "[FlowSensitive] Log analysis progress for debugging purposes". sammccall edited the summary of