[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c412b6c6faa: [BPF] Add a few new insns under cpu=v4 (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 544055. yonghong-song added a comment. - Add more tests in assembler-disassembler-v4.s and gotol.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 Files:

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

eddyz87 accepted this revision. eddyz87 added a comment. Hi Yonghong, Looks good to me, thanks! Before landing this, could you please adjust tests a little bit more? - Extend `assembler-disassembler-v4.s` with signed `div` and `mod`, e.g.: // CHECK: 3f 31 01 00 00 00 00 00 r1 s/= r3 //

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 543709. yonghong-song added a comment. Three major changes in this patch: - for ldsx insns, remove 32bit ldsx insns (1-byte and 2-byte sign extension) since the ldsx insn expects to sign extension all the way up to 8-byte and normal 32bit insn (e.g.

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song added a comment. > Could you please also add a few tests for `gotol`? Will do! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 ___ cfe-commits

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. Hi Yonghong, Thank you for the comments. Could you please also add a few tests for `gotol`? Sorry, I should have asked for those last week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:379 + "$dst = (s8)$src", + [(set GPR:$dst, (sra (shl GPR:$src, (i64 56)), (i64 56)))]>; + def MOVSX_rr_16 : ALU_RR I think it is possible to avoid

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

yonghong-song added a comment. In D144829#4519036 , @eddyz87 wrote: > I tried adding a test similar to `assemble-disassemble.ll`: > > // RUN: llvm-mc -triple bpfel --mcpu=v4 --assemble --filetype=obj %s \ > // RUN: | llvm-objdump -d --mattr=+alu32

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. I tried adding a test similar to `assemble-disassemble.ll`: // RUN: llvm-mc -triple bpfel --mcpu=v4 --assemble --filetype=obj %s \ // RUN: | llvm-objdump -d --mattr=+alu32 - \ // RUN: | FileCheck %s // CHECK: d7 01 00 00 10 00 00 00 r1 = bswap16 r1

[PATCH] D144829: [BPF] Add a few new insns under cpu=v4

ast accepted this revision. ast added a comment. lgtm. @eddyz87 pls take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 ___ cfe-commits mailing list