[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 542245. yonghong-song added a comment. - remove a copy-paste comment from s390 arch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 Files:

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. overall looks good. one small nit. Comment at: llvm/lib/Target/BPF/MCTargetDesc/BPFMCFixups.h:17 +enum FixupKind { + // These correspond directly to R_390_* relocations. +

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 541265. yonghong-song edited the summary of this revision. yonghong-song added a comment. - Dropping 'CPUv4' in some variable/function names and also in debug flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:56 def BPFNoALU32 : Predicate<"!Subtarget->getHasAlu32()">; +def BPFHasCPUv4_ldsx : Predicate<"Subtarget->getCPUv4_ldsx()">; +def BPFHasCPUv4_movsx : Predicate<"Subtarget->getCPUv4_movsx()">;

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:56 def BPFNoALU32 : Predicate<"!Subtarget->getHasAlu32()">; +def BPFHasCPUv4_ldsx : Predicate<"Subtarget->getCPUv4_ldsx()">; +def BPFHasCPUv4_movsx : Predicate<"Subtarget->getCPUv4_movsx()">;

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 539842. yonghong-song edited the summary of this revision. yonghong-song added a comment. - rename some insn names or mode names (movs -> movsx, lds -> ldsx, MEMS -> MEMSX) etc to be consistent with kernel. - add 5 llc flags to control on/off for each

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song added a comment. In D144829#4465193 , @eddyz87 wrote: > Hi Yonghong, > > What is the current plan for these changes? > I'd like to refresh D140804 to make BPF_ST > instruction available for cpu v4. > I

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. Hi Yonghong, What is the current plan for these changes? I'd like to refresh D140804 to make BPF_ST instruction available for cpu v4. I see that the latest CI run failed because of libcxx issue, I think it is completely unrelated to

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 534801. yonghong-song added a comment. - avoid changing conditions during JMP -> JMPL conversion. Otherwise, verification may fail in some cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 534361. yonghong-song added a comment. - added support of new instructions in inline assembly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 Files:

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 523569. yonghong-song edited the summary of this revision. yonghong-song added a comment. - Fixed previous llvm-objdump issue for '> 16bit' 'gotol' insns. - Now basic functionality for cpu=v4 should be complete for llvm, further work will focus on

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 523253. yonghong-song added a comment. - Fixed issues reported by Eduard - llvm-objdump issue (as stated in 'Summary') is not resolved yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. Hi Yonghong, Left a few nitpicks and one comment in `BPFMIPreEmitPeephole::adjustBranch()` that I think points to a bug. Overall `adjustBranch()` algorithm looks good. It would be great to have some test cases for it, e.g. preprocess test .ll by replacing some template

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In [1], a few new insns are proposed to exgend BPF ISA