[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65f7a84cf38b: [clang][ExtractAPI] Handle platform specific unavailability correctly (authored by Arsenic, committed by dang). Repository: rG LLVM

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM, It's worth noting that if the user specifies that an API is unavailable in a later redeclaration, this will be ignored. For example if I add a line to the test `void e(void)

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic updated this revision to Diff 501148. Arsenic added a comment. Add test to check platform specific unavailability The update also remove the useless changes that were introduced by using clang format on the entire file instead of current commit. Repository: rG LLVM Github Monorepo

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

dang added a comment. In D144940#4158143 , @Arsenic wrote: > In D144940#4158020 , @dang wrote: > >> Nice! glad to see this getting fixed. You should add a lit test to ensure we >> don't regress this behavior in

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic added a comment. In D144940#4158020 , @dang wrote: > Nice! glad to see this getting fixed. You should add a lit test to ensure we > don't regress this behavior in the future. I see a test checking for availability attribute already exists (

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed. Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future. Comment at:

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic created this revision. Herald added a reviewer: ributzka. Herald added a project: All. Arsenic edited the summary of this revision. Arsenic added reviewers: dang, zixuw. Arsenic published this revision for review. Arsenic added inline comments. Herald added a project: clang. Herald added a