This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf1440bf6fd22: Driver: introduce GNU spellings to control
MSVC paths (authored by compnerd).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
If others don't have anything to add on this matter, I guess this is fine.
The new option names feel rather wordy and unwieldy (especially compared to the
clang-cl forms they're aliases
compnerd added a comment.
Just a friendly reminder, I'd like to get this merged to do a follow up change
to improve some of the usability of these flags.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145007/new/
https://reviews.llvm.org/D145007
compnerd added a comment.
Yeah, I suspect that would be difficult. Additionally, these are aliases, so
they should already have testing coverage through the existing tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145007/new/
mstorsjo added reviewers: akhuang, hans, thakis, zahen, pkasting.
mstorsjo added a comment.
Looks reasonable to me, adding a few others for opinions. Should we have some
tests for this? I guess testing these is somewhat environment reliant though,
so it's probably not so easy...
Repository:
compnerd created this revision.
compnerd added reviewers: rnk, mstorsjo.
Herald added a project: All.
compnerd requested review of this revision.
Herald added a project: clang.
Add a set of `-Xmicrosoft` flags to control the Windows SDK and VisualC
tools directories. This allows control over the
