alexander-shaposhnikov updated this revision to Diff 503750.
alexander-shaposhnikov added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145034/new/
https://reviews.llvm.org/D145034
Files:
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:113-114
+ if (TemplateParamLists.size() == 1) {
+// FIXME: pick the correct template parameter list based on NNS, SS
+// and getCurScope().
+
alexander-shaposhnikov added inline comments.
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1677-1678
CXXScopeSpec Spec;
+if (TemplateInfo.TemplateParams)
+ Spec.setTemplateParamLists(*TemplateInfo.TemplateParams);
+
rsmith wrote:
> I think we'll
alexander-shaposhnikov updated this revision to Diff 502067.
alexander-shaposhnikov added a comment.
1/ Add support for out-of-line definitions of member enums + add tests
2/ Updated comments DeclSpec.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
shafik added inline comments.
Comment at: clang/include/clang/Sema/DeclSpec.h:68
NestedNameSpecifierLocBuilder Builder;
+ ArrayRef TemplateParamLists;
Does this really represent a `nested-name-specifier` with a
`template-param-list`? Maybe I am
rsmith added a comment.
This direction looks promising to me.
Comment at: clang/lib/Parse/ParseDeclCXX.cpp:1677-1678
CXXScopeSpec Spec;
+if (TemplateInfo.TemplateParams)
+ Spec.setTemplateParamLists(*TemplateInfo.TemplateParams);
+
I think we'll
alexander-shaposhnikov created this revision.
alexander-shaposhnikov added reviewers: rsmith, aaron.ballman.
alexander-shaposhnikov created this object with visibility "All Users".
Herald added a project: All.
alexander-shaposhnikov requested review of this revision.
Herald added a project: clang.
