This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG421c098b32bd: [Clang][Sema] Start fixing handling of
out-of-line definitions of constrained… (authored by alexander-shaposhnikov).
Repository:
rG
alexander-shaposhnikov updated this revision to Diff 504025.
alexander-shaposhnikov added a comment.
Release notes.
P.S. To the best of my knowledge the current status is the following: with this
patch the examples reported in the comments on
https://github.com/llvm/llvm-project/issues/49620
alexander-shaposhnikov added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:141
+ ClassTemplate->getInjectedClassNameSpecialization();
+ if (Context.hasSameType(Injected, ContextType))
+return ClassTemplate->getTemplatedDecl();
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good to me. This is fixing an important bug, and while there's more
cleanup I'd like for us to do, it seems important to get this fix landed first.
My understanding is that the release
alexander-shaposhnikov added inline comments.
Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:141
+ ClassTemplate->getInjectedClassNameSpecialization();
+ if (Context.hasSameType(Injected, ContextType))
+return ClassTemplate->getTemplatedDecl();