[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-14 Thread Snehasish Kumar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa1bbf5ac3cbd: [memprof] Record BuildIDs in the raw profile. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-13 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 ___ cfe-commits mailing list

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-13 Thread Snehasish Kumar via Phabricator via cfe-commits
snehasish updated this revision to Diff 504887. snehasish added a comment. Update the unittest in compiler-rt which was caught by the build bot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-13 Thread Snehasish Kumar via Phabricator via cfe-commits
snehasish reopened this revision. snehasish added a comment. This revision is now accepted and ready to land. Reopening since I missed the updates to the memprof unit tests in compiler-rt. This was caught by the buildbots. As part of the changes I modified the `SerializeToRawProfile` API

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-13 Thread Snehasish Kumar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG287177a47a39: [memprof] Record BuildIDs in the raw profile. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-11 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 ___ cfe-commits mailing list

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-09 Thread Snehasish Kumar via Phabricator via cfe-commits
snehasish updated this revision to Diff 503945. snehasish added a comment. Update test regex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 Files: clang/test/CodeGen/Inputs/memprof.exe

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-09 Thread Snehasish Kumar via Phabricator via cfe-commits
snehasish added a comment. In D145190#4181789 , @snehasish wrote: > In D145190#4181608 , @tejohnson > wrote: > >> lgtm - but does this depend on D145644 >> and require some

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

2023-03-09 Thread Snehasish Kumar via Phabricator via cfe-commits
snehasish updated this revision to Diff 503938. snehasish added a comment. Herald added subscribers: cfe-commits, wenlei. Herald added a project: clang. Update raw profiles, add another test for buildids only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION