[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon abandoned this revision. agozillon added a comment. Herald added a subscriber: bviyer. Closing this patch now that each individual component is upstreamed via seperate phabricator patches! Thank you to all the reviewers for your time and help. Repository: rG LLVM Github Monorepo

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. Fragmented this patch into https://reviews.llvm.org/D147344 (lowering) and https://reviews.llvm.org/D147324 (driver/tool changes and application of attribute). I will keep this patch open until the others are closed to give a big picture for easier reference.

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. In D145264#4236173 , @kiranchandramohan wrote: > Please split this patch into three: > > 1. Code changes and testing for the driver and the FIR+OpenMP dialect > generated. > 2. Code changes and test for FIR+OpenMP to

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Please split this patch into three: 1. Code changes and testing for the driver and the FIR+OpenMP dialect generated. 2. Code changes and test for FIR+OpenMP to

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. @agozillon Thanks for the updates, LGTM! Please wait for somebody to review the OpenMP changes before merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added inline comments. Comment at: clang/include/clang/Driver/Options.td:2692 def fno_openmp_assume_teams_oversubscription : Flag<["-"], "fno-openmp-assume-teams-oversubscription">, - Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; + Group,

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon updated this revision to Diff 509837. agozillon added a comment. Squash commits, format and apply requested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145264/new/ https://reviews.llvm.org/D145264 Files:

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added inline comments. Comment at: flang/tools/bbc/CMakeLists.txt:29 FortranLower +flangFrontendTool ) agozillon wrote: > awarzynski wrote: > > This a frontend driver library and so far `bbc` and `flang-new -fc1` have > > been entirely separate.

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added inline comments. Comment at: clang/include/clang/Driver/Options.td:2692 def fno_openmp_assume_teams_oversubscription : Flag<["-"], "fno-openmp-assume-teams-oversubscription">, - Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; + Group,

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

awarzynski added a comment. The driver plumbing looks good to me. I will defer reviewing the OpenMP changes to experts. Thanks for working on this! Comment at: clang/include/clang/Driver/Options.td:2692 def fno_openmp_assume_teams_oversubscription : Flag<["-"],

[PATCH] D145264: [OpenMP][MLIR][Flang][Driver][bbc] Lower and apply Module FlagsAttr

agozillon added a comment. Unfortunately I do not believe an mlir-translate test that tests if the OffloadModuleInterface is accessible when directly utilizing mlir-translate is possible for this patch... I forgot I removed the is device check as it is already done at the initial creation of