[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings abandoned this revision. michaelplatings marked an inline comment as done. michaelplatings added a comment. We're going back to "flags": https://discourse.llvm.org/t/rfc-multilib/67494/14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @peter.smith. I've opted to leave the comment as-is. If we can expect a tag_set to actually contain flags then I've continued to use that terminology. Comment at:

[PATCH] D145567: [Driver] Rename multilib flags to tags

peter.smith accepted this revision. peter.smith added a comment. Actually click the button this time to set approval, see previous comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567

[PATCH] D145567: [Driver] Rename multilib flags to tags

peter.smith added a comment. I've set approved from the Arm side. Please leave some time for people in the US time zone to leave any final comments or ask for extensions. From looking at the source code alone - assuming that most people would not track down the commit message/review for extra

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503913. michaelplatings added a comment. Tiny tweak: undo an unnecessary change to a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings updated this revision to Diff 503899. michaelplatings added a comment. Rebase on top of D142905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567 Files:

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings added a comment. Thanks @MaskRay for taking a look and thanks @simon_tatham for the review of the change. This change affects existing code so I think it deserves its own commit, but I'll move it down the stack to before D142932 so that later

[PATCH] D145567: [Driver] Rename multilib flags to tags

simon_tatham added inline comments. Comment at: clang/docs/Multilib.rst:71 + arguments into a standard set of simpler "tags". In many cases these tags will look like a command line argument with the leading ``-`` stripped off, + but where a suitable form for the tag

[PATCH] D145567: [Driver] Rename multilib flags to tags

simon_tatham added a comment. But it was useful to have it separate at least for review purposes, since it made it much easier when Michael asked me to proofread the change from 'flags' to 'tags'! Comment at: clang/docs/Multilib.rst:66 ``--target=armv7m-none-eabi`` are

[PATCH] D145567: [Driver] Rename multilib flags to tags

MaskRay added a comment. Since the touched code is still in review, you need to merge the changes into the prior patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145567/new/ https://reviews.llvm.org/D145567

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The name "flag"