[PATCH] D145765: Add __builtin_set_flt_rounds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xiongji90 marked an inline comment as not done. Closed by commit rGb38aa2971711: Add __builtin_set_flt_rounds (authored by xiongji90). Changed prior to commit:

[PATCH] D145765: Add __builtin_set_flt_rounds

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D145765#4191800 , @xiongji90 wrote: > I have simplified the test as you suggested and I also updated release doc to > add

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 added a comment. In D145765#4189153 , @aaron.ballman wrote: > Thanks for the additional tests! Can you also add a release note to > `clang/docs/ReleaseNotes.rst` and document the new builtin in > `clang\docs\LanguageExtensions.rst`? Hi,

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 504957. xiongji90 marked an inline comment as done. xiongji90 added a comment. Simplify test and update release doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145765/new/ https://reviews.llvm.org/D145765

[PATCH] D145765: Add __builtin_set_flt_rounds

aaron.ballman added a comment. Thanks for the additional tests! Can you also add a release note to `clang/docs/ReleaseNotes.rst` and document the new builtin in `clang\docs\LanguageExtensions.rst`? Comment at: clang/test/Sema/builtin_set_flt_rounds.c:1-11 +// RUN: %clang_cc1

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 504508. xiongji90 added a comment. Add SemaChecking test for incompatible input arguments for __builtin_set_flt_rounds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145765/new/

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 marked an inline comment as done. xiongji90 added inline comments. Comment at: clang/test/CodeGen/builtin_set_flt_rounds.c:5-7 +void test_builtin_set_flt_rounds() { + __builtin_set_flt_rounds(1); + // CHECK: call void @llvm.set.rounding(i32 1)

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 504504. xiongji90 added a comment. Add semachecking test for unsupported platform. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145765/new/ https://reviews.llvm.org/D145765 Files:

[PATCH] D145765: Add __builtin_set_flt_rounds

aaron.ballman added a comment. Thank you for this! You should also add a release note and some documentation for the new builtin. Comment at: clang/test/CodeGen/builtin_set_flt_rounds.c:1-4 +// RUN: %clang_cc1 -triple x86_64-gnu-linux %s -emit-llvm -o - | FileCheck %s +//

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 added a comment. Hi, @andrew.w.kaylor @rjmccall @sepavloff @aaron.ballman This patch re-lands previous patch to add __builtin_set_flt_rounds, previous patch broke PPC64 buildbot due to test case bug. Previously, tests for __builtin_set_flt_rounds was located in CodeGen/builtin.c

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 created this revision. xiongji90 added reviewers: andrew.w.kaylor, rjmccall, sepavloff, aaron.ballman. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. xiongji90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: