This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rG7ab16be4c030: [clangd] UnusedIncludes: Strict config now
uses the include-cleaner-library… (authored by
hokein updated this revision to Diff 504073.
hokein added a comment.
Herald added a subscriber: mgrang.
add the removal of the clangd-own implementation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145773/new/
https://reviews.llvm.org/D145773
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:438
+ .map("Experiment",
+
hokein added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:438
+ .map("Experiment",
+ Config::IncludesPolicy::Strict) // for backward
+ //
hokein updated this revision to Diff 504069.
hokein marked an inline comment as done.
hokein added a comment.
Add diagnostic for Experiment flag usage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145773/new/
https://reviews.llvm.org/D145773
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:438
+ .map("Experiment",
+ Config::IncludesPolicy::Strict) // for backward
+
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is the first step to