jhuber6 updated this revision to Diff 505166.
jhuber6 added a comment.
Adding release notes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145941/new/
https://reviews.llvm.org/D145941
Files:
clang/docs/ReleaseNotes.rst
arsenm added a comment.
Release note change should be here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145941/new/
https://reviews.llvm.org/D145941
___
cfe-commits mailing list
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
While `--no-undefined` is an alias for `-z defs`, be consistent in the subject
and the body.
> Always use -zdefs
`--no-undefined`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
jhuber6 updated this revision to Diff 504818.
jhuber6 added a comment.
Use `--no-undefined` to be consistent with HIP and check for OpenCL.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145941/new/
https://reviews.llvm.org/D145941
Files:
jhuber6 added a comment.
This can be turned off with `-zundefs`. So we could instruct people to use
`-Wl,-zundefs` or `-Xoffload-linker -zundefs` if the old behavior is desired.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145941/new/
JonChesterfield added a reviewer: AMDGPU.
JonChesterfield added a comment.
Adding the amdgpu reviewer group. This change might be contentious - we
currently treat various broken code as calls to trap on the grounds that those
functions might not be executed. By analogy, functions that call
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, JonChesterfield, arsenm, yaxunl, MaskRay.
Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits,
