[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

2023-03-14 Thread Nikita Popov via Phabricator via cfe-commits
nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Please split out the fixes to individual passes. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:48 + cl::Hidden,

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

2023-03-13 Thread Yevgeny Rouban via Phabricator via cfe-commits
yrouban added a comment. Looks good in general, but it would be better to have this patch split into several smaller patches: renaming NFC, InstructionCounter intro, one for each particular pass fix. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1057 + struct Inst

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

2023-03-13 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. Herald added subscribers: ormris, ChuanqiXu, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. CoroCleanup was running Simpl