[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-22 Thread Saleem Abdulrasool via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG893ce5759fe2: docs: add some documentation on Windows SDK search (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D146165?vs=506978=507346#toc Repository: rG LLVM Github

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-21 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Nice, thanks for taking the time to expand on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146165/new/ https://reviews.llvm.org/D146165 ___ cfe-commits mailing list

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-21 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd updated this revision to Diff 506978. compnerd added a comment. Update to include additional behaviour and reference `INCLUDE` and `LIB`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146165/new/ https://reviews.llvm.org/D146165 Files:

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-20 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd marked an inline comment as not done. compnerd added inline comments. Comment at: clang/docs/UsersManual.rst:4504 +programs against the Windows system packages. Underlying the Windows SDK is the +UCRT, the universal C runtime. + hans wrote: >

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-20 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/UsersManual.rst:4504 +programs against the Windows system packages. Underlying the Windows SDK is the +UCRT, the universal C runtime. +

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-20 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. > Looks reasonable I guess - but I think it would be good to mention the env > variables INCLUDE and LIB too, for alternative ways of finding the same > things - even if it's not strictly the same as what this new section talks > about. Yes, I agree, I did miss that

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-16 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Nice, thanks for doing this! Comment at: clang/docs/UsersManual.rst:4537 + +TODO: This is not yet implemented. + But isn't this how clang-cl finds stuff when running in a "Visual Studio Command Prompt" / setenv / vcvars or whatever

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-15 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Looks reasonable I guess - but I think it would be good to mention the env variables `INCLUDE` and `LIB` too, for alternative ways of finding the same things - even if it's not strictly the same as what this new section talks about. Repository: rG LLVM Github

[PATCH] D146165: docs: add some documentation on Windows SDK search

2023-03-15 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added reviewers: hans, rnk, mstorsjo. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. Add some documentation on the flags and the process by which clang identifies the headers and libraries for the