[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG9644368f974a: [clang-tidy] Fix checks filter with warnings-as-errors (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D146520?vs=543185=543222#toc Repository: rG LLVM Github

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

PiotrZSL updated this revision to Diff 543185. PiotrZSL edited the summary of this revision. PiotrZSL added a comment. Add test & release notes. Cleanup commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

PiotrZSL added a comment. Look into clang-tools-extra/test/clang-tidy/infrastructure/ for tests, probably you could base on one of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. I'm not sure how to test this, is there any check dependency we can rely on with hardcoded tests ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. It would still be good to add some test that ensures this does not happen again in the future, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Having another look and reading your comments I got a better understanding of the situation: - YAML output did not have correct warnings as errors. - Thus a fix was introduced in ClangTidyDiagnosticConsumer, however this was a

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

tiagoma added a comment. Applying this patch seems to fix issues with C++20 as well. See https://github.com/llvm/llvm-project/issues/61969 Can we get it in? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

aaron.ballman added a subscriber: NoQ. aaron.ballman added a comment. In D146520#4224483 , @PiotrZSL wrote: > In D146520#4224281 , @aaron.ballman > wrote: > >> Ideally, users should be able to disable the core

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

PiotrZSL added a comment. In D146520#4224281 , @aaron.ballman wrote: > Ideally, users should be able to disable the core checks from running at all > (the reason users want to disable checks is both because of the diagnostics > they produce and

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

aaron.ballman added a comment. In D146520#4221314 , @carlosgalvezp wrote: > Reading through Github I found the associated ticket (it would be good if you > could mention it in the commit message): > https://github.com/llvm/llvm-project/issues/61520 > >

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz added a comment. Your understanding is correct, I'm currently just trying to hide them at the end (warnings-as-errors or not). This is how it worked until 5d12b13b0b26bc58b02ee23c369da8b83240cceb (present in LLVM 16)

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. Reading through Github I found the associated ticket (it would be good if you could mention it in the commit message): https://github.com/llvm/llvm-project/issues/61520 So if I understand correctly, what you are trying to do is continue to let the

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. Also, regarding clang-analyzer-core checks, I have 2 tickets open: https://github.com/llvm/llvm-project/issues/59588 https://github.com/llvm/llvm-project/issues/59589 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

carlosgalvezp added a comment. I'm not sure I follow - if you enable warnings as error for all checks, then the expectation is that you indeed get an error if you violate one of the clang-analyzer checks. In what way is this not wanted? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Looks fine, and looks like it's working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146520/new/ https://reviews.llvm.org/D146520

[PATCH] D146520: [clang-tidy] Fix checks filter with warnings-as-errors

kiwixz created this revision. kiwixz added a reviewer: njames93. kiwixz added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. kiwixz requested review of this revision. Herald added a subscriber: cfe-commits. Since commit