This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc13ccf1fbabe: [clang][ExtractAPI]Fix Declaration fragments
for instancetype in the type… (authored by chaitanyav).
Repository:
rG LLVM Github Mono
dang accepted this revision.
dang added a comment.
Yup looks fine to me!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146671/new/
https://reviews.llvm.org/D146671
___
cfe-commits mailing list
cfe-commit
chaitanyav added a comment.
@dang Please review the test/output.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146671/new/
https://reviews.llvm.org/D146671
___
cfe-commits mailing list
cfe-commits@lists.
chaitanyav updated this revision to Diff 507725.
chaitanyav added a comment.
update test to check for id type
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146671/new/
https://reviews.llvm.org/D146671
Files:
clang/lib/ExtractAPI/DeclarationFragm
chaitanyav added a comment.
Will update the test to also include a Id instance method.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146671/new/
https://reviews.llvm.org/D146671
___
cfe-commits mailing l
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM, but you should also check in the test that `id` still renders as
expected.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146671/new/
https:/
