whisperity requested changes to this revision.
whisperity added a comment.
Earlier (IIRC in March) we did an internal test of the check and the following
results were obtained. The results are kinda //weird//, to say the least.
Numbers are //after// CodeChecker has done a serverside uniqueing (m
PiotrZSL requested changes to this revision.
PiotrZSL added a comment.
This revision now requires changes to proceed.
Additionally, fix build.
Once you finish making changes to this review, switch it back to ready for
review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/clang-tidy/portability/NonPortableIntegerConstantCheck.cpp:92
+void NonPortableIntegerConstantCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(integerLiteral().bind("integer"), this);
+}
--
Eugene.Zelenko added a comment.
Please add alias entry in Release Notes.
Comment at:
clang-tools-extra/clang-tidy/portability/NonPortableIntegerConstantCheck.cpp:95
+
+
+void NonPortableIntegerConstantCheck::check(
Excessive newline.
Comment
Discookie created this revision.
Discookie added reviewers: aaron.ballman, njames93, carlosgalvezp.
Discookie added a project: clang-tools-extra.
Herald added subscribers: PiotrZSL, ChuanqiXu, xazax.hun.
Herald added a project: All.
Discookie requested review of this revision.
This check finds int
