[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9972c9a89347: [NFC] Remove unused member variable `PolicyBitMask` in SemaRecord (authored by schittir). Repository: rG LLVM Github Monorepo

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should fix up the commit message when you land since the patch has changed away from what's described in the summary. CHANGES SINCE LAST ACTION

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir updated this revision to Diff 508221. schittir added a comment. Deleting the member PolicyBitMask CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146847/new/ https://reviews.llvm.org/D146847 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index:

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

jrtc27 added a comment. In D146847#4220721 , @schittir wrote: > In D146847#4220697 , @jrtc27 wrote: > >> None of the other fields are initialised, so blindly initialising it alone >> to 0 here seems highly

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir added a comment. In D146847#4220717 , @jrtc27 wrote: > The field should just be deleted. D126742 > added it without any uses, and I don't know what the original intent was. > Maybe it was used before the

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir added a comment. In D146847#4220697 , @jrtc27 wrote: > None of the other fields are initialised, so blindly initialising it alone to > 0 here seems highly suspect. What's the actual case in which it's used whilst > uninitialised? Coverity

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

jrtc27 added a comment. The field should just be deleted. D126742 added it without any uses, and I don't know what the original intent was. Maybe it was used before the bitfields were added and it stuck around rather than being GC'ed. I don't know why

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir updated this revision to Diff 508215. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146847/new/ https://reviews.llvm.org/D146847 Files: clang/utils/TableGen/RISCVVEmitter.cpp Index: clang/utils/TableGen/RISCVVEmitter.cpp

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

jrtc27 added a comment. None of the other fields are initialised, so blindly initialising it alone to 0 here seems highly suspect. What's the actual case in which it's used whilst uninitialised? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146847: [NFC] Fix uninitialized member variable use in RVVEmitter::createRVVIntrinsics()

schittir created this revision. schittir added reviewers: tahonermann, shafik, aaron.ballman. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD,