Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

2015-11-18 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253466: [libclang] Add entry points that take a full command line including argv[0]. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D14695?vs=40269&id=40513#toc Repository: rL LL

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

2015-11-18 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D14695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

2015-11-16 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 40269. bkramer added a comment. - Add a test case to make sure argv[0] handling actually works. - Clarify comments a bit. http://reviews.llvm.org/D14695 Files: include/clang-c/Index.h lib/Frontend/CreateInvocationFromCommandLine.cpp tools/diagtool/Sho

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

2015-11-16 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang-c/Index.h:5694-5695 @@ -5683,1 +5693,4 @@ /** + * \brief Same as clang_indexSourceFile but requires a full command line + * for \c command_line_args including argv[0]. + */ We should probably expand on why u

[PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

2015-11-16 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This provides both a more uniform interface and makes libclang behave like clang tooling wrt relative paths against argv[0]. This is necessary for finding paths to a c++ standard library relat