This revision was automatically updated to reflect the committed changes.
Closed by commit rGb356cd70a27d: [hwasan] remove requirment for PIE (authored
by Enna1).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147121/new/
vitalybuka removed 1 blocking reviewer(s): eugenis.
vitalybuka added a comment.
This revision is now accepted and ready to land.
Feel free to land. It works on my arm linux setup.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147121/new/
eugenis added a comment.
Sorry, I do not remember why this requirement is there. Must be related to
shadow / allocator placement and kernel mapping conflicts, but hwasan is using
dynamic shadow so that should not be an issue... LGTM as long as it works.
Repository:
rG LLVM Github Monorepo
Enna1 added a comment.
gentle ping, @eugenis PTAL, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147121/new/
https://reviews.llvm.org/D147121
___
cfe-commits mailing list
vitalybuka removed a reviewer: alekseyshl. vitalybuka added 1 blocking
reviewer(s): eugenis.
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision now requires review to proceed.
I don't know why HWASAN may required pie, but @eugenis seems confident on
D44745
Enna1 updated this revision to Diff 509611.
Enna1 added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147121/new/
https://reviews.llvm.org/D147121
Files:
clang/lib/Driver/SanitizerArgs.cpp
clang/test/Driver/sanitizer-ld.c
Enna1 created this revision.
Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, cryptoad.
Herald added a project: All.
Enna1 updated this revision to Diff 509252.
Enna1 added a comment.
Enna1 edited the summary of this revision.
Enna1 added reviewers: eugenis, alekseyshl, pcc,
