[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

This revision was automatically updated to reflect the committed changes. Closed by commit rG094a63a20bf5: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 556656. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 552427. skatrak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551497. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551454. skatrak added a comment. Rebase patch to fix unrelated build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files:

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551150. skatrak added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551088. skatrak added a comment. Herald added subscribers: gysit, Dinistro. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files:

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

jsjodin accepted this revision. jsjodin added a comment. This revision is now accepted and ready to land. I think this is fine. The dependent diff has already been approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 527380. skatrak added a comment. Update with latest main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5291 +Function *OpenMPIRBuilder::createRegisterRequires(StringRef Name) { + // Skip the creation of the registration function if this is device codegen jsjodin wrote: >

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

jsjodin added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5291 +Function *OpenMPIRBuilder::createRegisterRequires(StringRef Name) { + // Skip the creation of the registration function if this is device codegen Perhaps this function

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 520374. skatrak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 518677. skatrak edited the summary of this revision. skatrak added a comment. Herald added subscribers: bviyer, Moerafaat, zero9178, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak added a comment. I have been able to track down the failed `lld.wasm::stub_library.s` unit test to be due to the buildbot picking up line endings for the `lld/test/wasm/Inputs/libstub.so` to be Windows ones ("\r\n"), so the condition `if (mbref.getBuffer().starts_with("#STUB\n"))` in

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 515684. skatrak added a comment. Avoid creating registration function for the device. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files:

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 512805. skatrak added a comment. Add unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, agozillon. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. skatrak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: