[PATCH] D147395: [Clangd] Make the type hint length limit configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae1aa9da788: [Clangd] Make the type hint length limit configurable (authored by zhangyi1357, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein added a comment. In D147395#4253753 , @zhangyi1357 wrote: > I dont have commit access. Could you help committing the change for me? > @hokein sure, I will land it for you (sorry for the late response). Comment at:

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 added a comment. I dont have commit access. Could you help committing the change for me? @hokein Comment at: clang-tools-extra/clangd/Config.h:151 +// Limit the length of type names in inlay hints. +size_t TypeNameLimit = 32; } InlayHints;

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 511955. zhangyi1357 marked an inline comment as done. zhangyi1357 added a comment. Combine mutiple commits into single one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 511950. zhangyi1357 marked 2 inline comments as done. zhangyi1357 added a comment. - [Clangd] Remove unneccessary modification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good with a nit. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:80 C.InlayHints.Designators = false; + C.InlayHints.TypeNameLimit = 1;

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510795. zhangyi1357 added a comment. - [Clangd] Add unittest for TypeNameLimit config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/ https://reviews.llvm.org/D147395 Files:

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein added inline comments. Comment at: clang-tools-extra/clangd/Config.h:151 +// Limit the length of type names in inlay hints. +size_t TypeNameLimit = 32; } InlayHints; zhangyi1357 wrote: > hokein wrote: > > I would extend it a bit more -- 0 means

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 added a comment. In D147395#4240227 , @hokein wrote: > Thanks for the contribution! It's quite interesting for me. Thanks for your time reviewing and your great advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510521. zhangyi1357 marked an inline comment as not done. zhangyi1357 added a comment. Try to fix the build problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 marked 2 inline comments as done. zhangyi1357 added a comment. In D147395#4240227 , @hokein wrote: > Thanks for the contribution! It's really interesting for me. Thanks for your time reviewing! Comment at:

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510508. zhangyi1357 added a comment. Add uint32Value() for uint32_t type parsing in config file. For TypeNameLimit config, support no limit with value 0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein added a comment. Thanks for the contribution! Comment at: clang-tools-extra/clangd/Config.h:151 +// Limit the length of type names in inlay hints. +size_t TypeNameLimit = 32; } InlayHints; I would extend it a bit more -- 0 means no limit.

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 updated this revision to Diff 510292. zhangyi1357 added a comment. Format code modified using clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147395/new/ https://reviews.llvm.org/D147395 Files:

[PATCH] D147395: [Clangd] Make the type hint length limit configurable

zhangyi1357 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zhangyi1357 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github