[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ec36e6956cb: [clang][modules] Handle explicit modules when checking for .Private - _Private (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 ___ cfe-commits mailing list

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510629. benlangmuir added a comment. Upload correct diff this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510628. benlangmuir added a comment. Also test eagerly-loaded pcm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

jansvoboda11 added inline comments. Comment at: clang/test/Modules/implicit-private-with-submodule-explicit.m:9 +// RUN: %clang_cc1 -x objective-c -fmodules -fno-implicit-modules -emit-module -fmodule-name=A_Private %t/module.modulemap -o %t/A_Private.pcm +// RUN: %clang_cc1 -x

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir updated this revision to Diff 510623. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147477/new/ https://reviews.llvm.org/D147477 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Modules/implicit-private-with-submodule-explicit.m Index:

[PATCH] D147477: [clang][modules] Handle explicit modules when checking for .Private -> _Private

benlangmuir created this revision. benlangmuir added reviewers: akyrtzi, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While we eventually want to remove the mapping from .Private to