[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG35ff5eba1646: [RISCV][MC] Add support for experimental Zfbfmin extension (authored by asb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. Can you merge this patch since I want to suppport support __bf16 in clang which will rely on FeatureStdExtZfbfmin? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___ cfe-commits mailing list

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb updated this revision to Diff 523016. asb edited the summary of this revision. asb added a comment. Now updated to reflect v0.6 of the spec and should be ready for final review and merge https://github.com/riscv/riscv-bfloat16/releases/tag/main CHANGES SINCE LAST ACTION

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. In D147610#4297533 , @joshua-arch1 wrote: >> The RVI toolchain SIG is supposed to be setting up a task group to define >> intrinsics for all extensions. > > Where should I discuss this intrinsic issue right now? I guess

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. > The RVI toolchain SIG is supposed to be setting up a task group to define > intrinsics for all extensions. Where should I discuss this intrinsic issue right now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. In D147610#4294322 , @joshua-arch1 wrote: > In D147610#4294260 , @craig.topper > wrote: > >> In D147610#4294247 , @joshua-arch1 >> wrote:

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. In D147610#4294260 , @craig.topper wrote: > In D147610#4294247 , @joshua-arch1 > wrote: > >> I'm wondering whether it is appropriate to just use FPR16 for the >> destination of

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. In D147610#4294247 , @joshua-arch1 wrote: > I'm wondering whether it is appropriate to just use FPR16 for the destination > of fcvt.bf16.s? The destination is in BF16 format instead of simple FP16. > Your implemention

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. I'm wondering whether it is appropriate to just use FPR16 for the destination of fcvt.bf16.s? The destination is in BF16 format instead of simple FP16. Your implemention looks like just replacing fcvt.h.s with fcvt.bf16.s. Do we need to define a new register

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. What's the difference between fcvt.bf16.s and fcvt.h.s? In your implementation, it seems that you just replace fcvt.h.s with fcvt.bf16.s in Zfbfmin extension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb updated this revision to Diff 512743. asb edited the summary of this revision. asb added a comment. Rebase and use the new encoding suggested in https://github.com/riscv/riscv-bfloat16/issues/33 - hoping for the commits that alter the encoding to be pushed to the spec repo and a new PDF

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb updated this revision to Diff 511080. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib/Support/RISCVISAInfo.cpp

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,