[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b1cec065227: [clangd] Add batch fixes for include-cleaner diagnostics (authored by hokein). Changed prior to commit:

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443 + RemoveAll.Annotations.push_back({RemoveAllUnusedID, + {/*label=*/"", /*needsConfirmation=*/true, +

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517157. hokein added a comment. fix the lit-test uri path on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files:

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517154. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files:

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443 + RemoveAll.Annotations.push_back({RemoveAllUnusedID, + {/*label=*/"", /*needsConfirmation=*/true, +

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:443 + RemoveAll.Annotations.push_back({RemoveAllUnusedID, + {/*label=*/"", /*needsConfirmation=*/true, +

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517096. hokein added a comment. more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 517093. hokein marked 8 inline comments as done. hokein added a comment. address review comments: - emit one annotation per textedit; - remove unnecessary std::optional in the protocol structure - add a lit test Repository: rG LLVM Github Monorepo

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet added a comment. can you also add test coverage for the new LSP fields? Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:439 + for (auto : RemoveAll.Edits) { +E.annotationId.emplace(); +*E.annotationId = RemoveAllUnusedID; nit:

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added a comment. I have extended this patch a bit more (including the LSP `ChangeAnnotation` support part), it is based on https://reviews.llvm.org/D148783), and it implements a full workflow of batch fixes (verified it with VSCode). I hope it is not too big to review, happy to split it

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 516384. hokein added a comment. some cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 516382. hokein marked 6 inline comments as done. hokein added a comment. - address review comments - add LSP's ChangeAnnotations support and use it in the include-cleaner batch fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:418 +Fix removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes) { + Fix RemoveAll; can we also derive these from an `llvm::ArrayRef` ? to make sure there can't be a

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added a comment. The UI in VSCode looks like - unused-include: F27034770: image.png - missing-include: F27034749: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. For each