[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon updated this revision to Diff 530434. Fznamznon added a comment. Rebase, update value of macro since P2564 is implemented now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

philnik added a comment. https://github.com/llvm/llvm-project/issues/60709 seems also pretty scary to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cor3ntin added a comment. Works for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

aaron.ballman added a comment. In D147717#4396432 , @cjdb wrote: > In D147717#4395204 , @Fznamznon > wrote: > >> In D147717#4393019 , @cor3ntin >> wrote: >> >>> I think

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4395204 , @Fznamznon wrote: > In D147717#4393019 , @cor3ntin > wrote: > >> I think we should make sure to land this for clang 17. The rate of consteval >> bugs is no greater

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon added a comment. In D147717#4393019 , @cor3ntin wrote: > I think we should make sure to land this for clang 17. The rate of consteval > bugs is no greater than that of any other feature at this point. There is

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cor3ntin added a comment. I think we should make sure to land this for clang 17. The rate of consteval bugs is no greater than that of any other feature at this point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon added a comment. Friendly ping. It is been a while. @cjdb , any chance for an update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4312066 , @Fznamznon wrote: > In D147717#4275410 , @cjdb wrote: > >> I'm gonna get started on this today! > > @cjdb , how is this going? I've seen >

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon added a comment. In D147717#4275410 , @cjdb wrote: > I'm gonna get started on this today! @cjdb , how is this going? I've seen https://github.com/llvm/llvm-project/issues/62224, but no more issues with consteval label. Repository: rG

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. I'm gonna get started on this today! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits mailing list

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

aaron.ballman added a comment. In D147717#4249929 , @cjdb wrote: > In D147717#4248989 , @erichkeane > wrote: > >> @cjdb has been running some GDB test suites against our compiler: I am >> wondering if we could

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4248989 , @erichkeane wrote: > @cjdb has been running some GDB test suites against our compiler: I am > wondering if we could ask him to try the consteval ones too before we set > this? A lot of that work is manual

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

shafik added a comment. In D147717#4248989 , @erichkeane wrote: > @cjdb has been running some GDB test suites against our compiler: I am > wondering if we could ask him to try the consteval ones too before we set > this? This is probably a good idea.

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

erichkeane added a subscriber: cjdb. erichkeane added a comment. @cjdb has been running some GDB test suites against our compiler: I am wondering if we could ask him to try the consteval ones too before we set this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cor3ntin added a comment. LGTM. Thanks for completing this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits mailing list

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After resolving several outstanding issues now is the time to mark it as fully supported. Fixes