[PATCH] D147848: [clang] Add test for CWG2370

2023-04-11 Thread Vlad Serebrennikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfeb93d28b02c: [clang] Add test for CWG2370 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147848/new/ https://reviews.llvm.org/D147848

[PATCH] D147848: [clang] Add test for CWG2370

2023-04-11 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CXX/drs/dr23xx.cpp:182 + typedef N::type N_type; + // FIXME: `type` should be searched for in N + // friend void N::g(type);

[PATCH] D147848: [clang] Add test for CWG2370

2023-04-11 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. Bug report filed: https://github.com/llvm/llvm-project/issues/62061 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147848/new/ https://reviews.llvm.org/D147848 ___ cfe-commits

[PATCH] D147848: [clang] Add test for CWG2370

2023-04-11 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:182 + typedef N::type N_type; + // FIXME: `type` should be searched for in N + // friend void N::g(type); shafik wrote: > The implementation seems to all accept this example: >

[PATCH] D147848: [clang] Add test for CWG2370

2023-04-10 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:182 + typedef N::type N_type; + // FIXME: `type` should be searched for in N + // friend void N::g(type); The implementation seems to all accept this example:

[PATCH] D147848: [clang] Add test for CWG2370

2023-04-08 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2370 is resolved by performing a search in