[PATCH] D147888: Update declaration message of extern linkage

aaron.ballman added a comment. In D147888#4467002 , @Krishna-13-cyber wrote: > In D147888#4466998 , @aaron.ballman > wrote: > >> I think the existing wording is pretty reasonable, changing "non-static >>

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4466998 , @aaron.ballman wrote: > I think the existing wording is pretty reasonable, changing "non-static > declaration" into "extern declaration" isn't really giving the user any more > information to help

[PATCH] D147888: Update declaration message of extern linkage

aaron.ballman added a comment. I think the existing wording is pretty reasonable, changing "non-static declaration" into "extern declaration" isn't really giving the user any more information to help them resolve the issue. "please pick exactly one" doesn't seem likely to help the user either

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4463163 , @tbaeder wrote: > Ping. Thanks for the ping! Does this require any further modification? I think if we will have to change the whole set of diagnostics if we go with this change of `pick exactly

[PATCH] D147888: Update declaration message of extern linkage

tbaeder added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147888/new/ https://reviews.llvm.org/D147888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4288149 , @Krishna-13-cyber wrote: > I have tried a little modification from my side thinking on a beneficial > note. I will make the changes to all the other test files as well if this > diagnostic

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber updated this revision to Diff 515843. Krishna-13-cyber added a comment. I have tried a little modification from my side thinking on a beneficial note. I will make the changes to all the other test files as well if this diagnostic representation goes well after mentor review.

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4274763 , @cjdb wrote: > I think we should fundamentally rethink this entire category of diagnostic. > Rather than having a static diagnostic per offence stating //what// happened, > we should instead have a

[PATCH] D147888: Update declaration message of extern linkage

cjdb added a comment. I think we should fundamentally rethink this entire category of diagnostic. Rather than having a static diagnostic per offence stating //what// happened, we should instead have a single diagnostic that captures both what happened, why it's bad, and how to fix it.

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber updated this revision to Diff 512848. Krishna-13-cyber added a comment. - Updated with removing redundant flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147888/new/ https://reviews.llvm.org/D147888 Files:

[PATCH] D147888: Update declaration message of extern linkage

tbaeder added inline comments. Comment at: clang/test/SemaCXX/extern_static.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 -Wabstract-vbase-init +void f(void) That's unnecessary, isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: tbaeder, cjdb, aaron.ballman. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch aims to improve the diagnostic