This revision was automatically updated to reflect the committed changes.
Closed by commit rG77f191e81ed4: [clang-tidy] Improve bugprone-branch-clone
with support for fallthrough… (authored by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
donat.nagy accepted this revision.
donat.nagy added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147889/new/
https://reviews.llvm.org/D147889
PiotrZSL updated this revision to Diff 524769.
PiotrZSL marked 2 inline comments as done.
PiotrZSL added a comment.
Correct review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147889/new/
https://reviews.llvm.org/D147889
Files:
donat.nagy added a comment.
Mostly LGTM, I suggested two cosmetic changes.
Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:55
+bool TraverseLambdaExpr(LambdaExpr *, DataRecursionQueue * = nullptr) {
+ // Ignore lambdas
+ return true;
PiotrZSL updated this revision to Diff 524419.
PiotrZSL added a comment.
Rebase, Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147889/new/
https://reviews.llvm.org/D147889
Files:
clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
PiotrZSL created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Ignore duplicated
