This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbf2511bdd814: [6/11][POC][Clang][RISCV] Define tuple type
variant of vlsseg2e32 (authored by eopXD).
Repository:
rG LLVM Github Monorepo
CHANGES
eopXD updated this revision to Diff 523850.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147912/new/
https://reviews.llvm.org/D147912
Files:
clang/include/clang/Basic/riscv_vector.td
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147912/new/
https://reviews.llvm.org/D147912
eopXD updated this revision to Diff 523622.
eopXD added a comment.
Removed another variable that is too verbose.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147912/new/
https://reviews.llvm.org/D147912
Files:
eopXD updated this revision to Diff 523485.
eopXD marked an inline comment as done.
eopXD added a comment.
Address comments from Craig.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147912/new/
https://reviews.llvm.org/D147912
Files:
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1693
+ unsigned Offset = IsMasked ? 1 : 0;
+ llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr;
+ llvm::Value *PtrOperand = IsMasked ? Ops[1] : Ops[0];
eopXD updated this revision to Diff 522932.
eopXD added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147912/new/
https://reviews.llvm.org/D147912
Files:
clang/include/clang/Basic/riscv_vector.td
eopXD updated this revision to Diff 516301.
eopXD added a comment.
Address comment from Craig.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147912/new/
https://reviews.llvm.org/D147912
Files:
clang/include/clang/Basic/riscv_vector.td
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1914
+
+ llvm::Value *MaskOperand = IsMasked ? Ops[0] : nullptr;
+ llvm::Value *PtrOperand = IsMasked ? Ops[1] : Ops[0];
similar comment to what I left on the
