[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61346ed51fda: [11/11][POC][Clang][RISCV] Define vset for tuple type (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523867. eopXD added a comment. Add unsigned cast to eliminate compile warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files:

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523862. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523645. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files:

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2640 + llvm::Value *VOperand = Ops[2]; + assert(isa(IndexOperand)); + Drop this assert Comment at:

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 522953. eopXD added a comment. Rebase and resolve CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 516341. eopXD added a comment. Herald added a subscriber: arphaman. Add test case for out-of-range access and guard vset correctly under SemaChecking.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2763 + unsigned MaxIndex = cast(VTupleOperand->getType())->getNumElements(); + Index = std::min(Index, MaxIndex); + Does SemaChecking already guarantee