[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet added a comment. caea93cc4478cca28321cba4fa2871d5e6090299 should fix the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148112/new/

Re: [PATCH] D148112: [include-cleaner] Improve handling for templates

figured out the issue, preparing a fix On Wed, Apr 12, 2023 at 7:46 PM Douglas Yung via Phabricator < revi...@reviews.llvm.org> wrote: > dyung added a comment. > > @kadircet, your change is causing 3 test failures on Windows bots, can you > take a look and revert if you need time to investigate?

[PATCH] D148112: [include-cleaner] Improve handling for templates

dyung added a comment. @kadircet, your change is causing 3 test failures on Windows bots, can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/19740 https://lab.llvm.org/buildbot/#/builders/123/builds/18332 Repository: rG LLVM

[PATCH] D148112: [include-cleaner] Improve handling for templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34f5774920f5: [include-cleaner] Improve handling for templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:109 ADD_FAILURE() << DiagBuf << "\nfrom code:\n" << ReferencingCode; + llvm::sort(TargetDeclKinds); +

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet updated this revision to Diff 512851. kadircet marked an inline comment as done. kadircet added a comment. Herald added a subscriber: ChuanqiXu. - Ignore explicit instantiations - Update tests to use decls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148112: [include-cleaner] Improve handling for templates

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:91 +auto *CTSD = llvm::cast(TD); +if (CTSD->isExplicitInstantiationOrSpecialization()) +

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet updated this revision to Diff 512775. kadircet edited the summary of this revision. kadircet added a comment. - Use template instantion pattern helper instead of dealing with partial specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet created this revision. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Principal here is: - Making sure each template instantiation implies use