[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-14 Thread Vlad Serebrennikov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG576c752410e7: [clang] Add test for CWG1894 and CWG2199 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-14 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 513457. Endill added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148136/new/ https://reviews.llvm.org/D148136 Files: clang/test/CXX/drs/dr18xx.cpp clang/test/CXX/drs/dr21xx.cpp

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-14 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 Endill wrote: > erichkeane wrote: >

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 512910. Endill edited the summary of this revision. Endill added a comment. Remove parts of CWG1894 and CWG2199 tests that are resolved by CWG407 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148136/new/

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 erichkeane wrote: > Endill wrote: > > cor3ntin wrote: > > > I would just say "Yes", i think clang 3.8 predates these issues > >

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 Endill wrote: > cor3ntin wrote: > > I would just say "Yes", i think clang 3.8 predates these issues > It's not the case: 2199

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 cor3ntin wrote: > I would just say "Yes", i think clang 3.8 predates these issues It's not the case: 2199 was filed 12.11.2015,

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 I would just say "Yes", i think clang 3.8 predates these issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ Endill wrote: > cor3ntin

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. Thank you for taking a look at this. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ I think i would prefer

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

2023-04-12 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1894 and its duplicate CWG2199 are resolved