This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG053bdb77b0ce: [clang] Bump AS_GNU to 1 (authored by
rsandifo-arm).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rsandifo-arm updated this revision to Diff 512947.
rsandifo-arm added a comment.
Gah, sorry. Due to a botched git operation, I posted a first cut with a stupid
typo, rather than the version that passed testing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
erichkeane added inline comments.
Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135
AttributeCommonInfo(const IdentifierInfo *AttrName,
const IdentifierInfo *ScopeName, SourceRange AttrRange,
rsandifo-arm wrote:
>
rsandifo-arm added inline comments.
Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135
AttributeCommonInfo(const IdentifierInfo *AttrName,
const IdentifierInfo *ScopeName, SourceRange AttrRange,
erichkeane wrote:
> Did
erichkeane added inline comments.
Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:28
/// __attribute__((...))
-AS_GNU,
+AS_GNU = 1,
Note for others: we're now at 11 items (10 items + starting at 1), stored in 4
bits. So this doesn't
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
This LGTM, though curious about the re-ordering.
Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135
AttributeCommonInfo(const IdentifierInfo
rsandifo-arm created this revision.
rsandifo-arm added reviewers: erichkeane, aaron.ballman.
Herald added a project: All.
rsandifo-arm requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Following a suggestion from Erich in
